Only toLowerCase once

regalijan · Mar 26, 2024 · e5bbde2 · e5bbde2
1 parent 8bf794c
commit e5bbde2
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/functions/api/reports/submit.ts b/functions/api/reports/submit.ts
@@ -140,16 +140,14 @@ export async function onRequestPost(context: RequestContext) {
   const filesToProcess = [];
 
   for (const file of files) {
-    const fileParts = file.name.split(".");
+    const fileParts = file.name.split(".").toLowerCase();
     let fileExten = fileParts.at(-1);
 
-    if (fileExten.toLowerCase() === "mov") fileExten = "mp4";
+    if (fileExten === "mov") fileExten = "mp4";
 
     if (
       fileParts.length < 2 ||
-      !["mkv", "mp4", "wmv", "m4v", "gif", "webm"].includes(
-        fileExten.toLowerCase(),
-      )
+      !["mkv", "mp4", "wmv", "m4v", "gif", "webm"].includes(fileExten)
     )
       return jsonError(
         `File ${file.name} cannot be uploaded as it is unsupported`,
@@ -165,7 +163,7 @@ export async function onRequestPost(context: RequestContext) {
     uploadUrlPromises.push(
       upload(
         context.env,
-        `${["mp4", "m4v", "webm"].includes(fileExten.toLowerCase()) ? "" : "t/"}${fileUploadKey}`,
+        `${["mp4", "m4v", "webm"].includes(fileExten) ? "" : "t/"}${fileUploadKey}`,
         file.size,
         fileExten,
       ),