Handle unexpected exceptions better

regalijan · Oct 19, 2023 · 8967818 · 8967818
1 parent 8f05c32
commit 8967818
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/components/AppealCard.tsx b/components/AppealCard.tsx
@@ -62,9 +62,16 @@ export default function (props: AppealCardProps) {
 
       document.getElementById(`appeal_${props.id}`)?.remove();
     } else {
+      let error;
+
+      try {
+        error = ((await actionReq.json()) as { error: string }).error;
+      } catch {
+        error = "Unknown error";
+      }
       setLoading(false);
       toast({
-        description: ((await actionReq.json()) as { error: string }).error,
+        description: error,
         duration: 10000,
         status: "error",
         title: "Oops!",

diff --git a/functions/gcloud.ts b/functions/gcloud.ts
@@ -296,5 +296,5 @@ export async function sendPushNotification(
     },
   );
 
-  if (!notifResp.ok) throw new Error(await notifResp.json());
+  if (!notifResp.ok) throw new Error(await notifResp.text());
 }